Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate PrecompiledContractsArbOS30 in geth hook #2239

Merged
merged 5 commits into from
Apr 29, 2024

Conversation

anodar
Copy link
Contributor

@anodar anodar commented Apr 19, 2024

updates geth pin to include changes from OffchainLabs/go-ethereum#303

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Apr 19, 2024
@@ -67,6 +67,15 @@ func init() {
vm.PrecompiledAddressesArbitrum = append(vm.PrecompiledAddressesArbitrum, addr)
}

for addr, precompile := range vm.PrecompiledContractsArbitrum {
vm.PrecompiledContractsArbOS30[addr] = precompile
vm.PrecompiledAddressesArbOS30 = append(vm.PrecompiledAddressesArbOS30, addr)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed up a commit adding this line, which I think was missing

magicxyyz
magicxyyz previously approved these changes Apr 27, 2024
Copy link
Contributor

@magicxyyz magicxyyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower PlasmaPower marked this pull request as ready for review April 29, 2024 04:36
@PlasmaPower PlasmaPower requested a review from magicxyyz April 29, 2024 04:36
magicxyyz
magicxyyz previously approved these changes Apr 29, 2024
Copy link
Contributor

@magicxyyz magicxyyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@magicxyyz magicxyyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower PlasmaPower enabled auto-merge April 29, 2024 15:05
@PlasmaPower PlasmaPower merged commit faaaf30 into master Apr 29, 2024
8 checks passed
@PlasmaPower PlasmaPower deleted the secp256r1-precompile branch April 29, 2024 15:24
@PlasmaPower PlasmaPower added geth Involves changes to Go-Ethereum consensus labels May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consensus geth Involves changes to Go-Ethereum s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants